Open GoogleCodeExporter opened 8 years ago
This has been discussed in Google Groups (http://groups.google.com/group/rtgui/
browse_thread/thread/7f176f400ac1e3bf), but I'd like to see how you achive this
functionality - please post your patch :)
Original comment by lemonbe...@gmail.com
on 10 Nov 2009 at 8:07
[deleted comment]
Here my first version. We can also add download capability in dirbrwoser.php
Original comment by herrl...@gmail.com
on 13 Nov 2009 at 11:45
Attachments:
I thought it might be something like this -
while I'm not totally against it, it's really replicating standard Apache
functions
- why not allow directory listings (as per the Google groups discussion)?
I like to use the "KISS" principle (Keep It Simple), and this is goes against
that
principle.
..Unless many rtGui users would really find this functionallity useful...
Original comment by lemonbe...@gmail.com
on 14 Nov 2009 at 6:48
Some contras against dirlist.
1. With view.php you can see if a file is complete or not
2. During browsing some audio files in view.php I consider to download a one.
Then I
must enter something like /rtgui/listing and seek for this file in a dirlist
and then
click on it.
3. No rtgui look & feel.
4. No additional settings for dirlist enabling.
Anyway I use this patch at the moment and it is online, so everyone interessted
can
use it ;)
Original comment by herrl...@gmail.com
on 14 Nov 2009 at 7:24
What I might add is functionality to provide a link to view the file if a
config.php
variable is set, so that it uses the Apache dirlist to serve the file.
I've got nothing against anyone using this patch if they need it!
Original comment by lemonbe...@gmail.com
on 16 Nov 2009 at 10:15
Allowing Apache to do the serving maybe the quickest way (low overhead, no php
executions) it will require you to open your rtorrent output folder in Apache.
People may see this as too open, but I guess it depends on the usage.
Personally, Apache serving the content directly would make more sense as it
reduces
the extra code required (content mime type is a prime example in this patch).
You
can always secure the downloads with the related Auth settings.
Original comment by nikd...@gmail.com
on 24 Nov 2009 at 1:47
I would highly recommend using apache mod_xsendfile instead of an apache Index
list.
-> https://tn123.org/mod_xsendfile/
Especially because if you are like me, I have 3000+ torrents running in
rtorrent and many more thousand files from NFS shares (other torrent clients)
that would make an impossible list to scan through.
Xsendfile is very fast and very cool. I would use it in download.php on a
config file conditional ($usexsend boolean of some sort).
Now what *would* be a cool addon, would be similar to torrentflux, on the
completed torrents page, a download link be there that zip/tar(+gz,+bz,etc) the
file and streams it on to your browser.
Original comment by mediadae...@gmail.com
on 4 Jan 2012 at 1:12
Original issue reported on code.google.com by
herrl...@gmail.com
on 10 Nov 2009 at 2:48