hicknhack-software / redmine_time_tracker

A time tracker plugin for Redmine
Other
106 stars 32 forks source link

can't stop running timer .. results in "Booking could not be added!" #100

Closed cforce closed 9 years ago

cforce commented 11 years ago

i debugged into the code, and the line time_log.rb@111 if ib.persisted? returns false. In the params the activity is unset. If i select activity in tt_overview manually the selection box stays red as there is a problem. Also the stop button still is greyed out and not clickable, although project, issue and time is set.

jume-dev commented 11 years ago

Seems like your activity doesnt get set, which definitly does work for me. Make sure everything is installed correctly and you cleared the cache of your browser.

Maybe there is something wrong in your activities settings in redmine? For clarification try it on a fresh redmine installation.

cforce commented 11 years ago

I cleared the browser cache and i can't reinstall my production. All other things are working fine. Can u please help me to debug this problem from the code side. Where to pout what logs to get the cause?

cforce commented 11 years ago

Booking from standard redmine views and via commit messages works without problems. Its only not working in this plugin.

jume-dev commented 11 years ago

I dont have much time atm for this project. So please try it first on a fresh redmine installation. Just setup one local on your machine and see, if the error still occurs.

cforce commented 10 years ago

i think this same/is related to #97

sasselin commented 10 years ago

I have the same bug here, i try to reinstall a fresh install of redmine 2.3.2 tonight. If work, I tell you ;)

cforce commented 10 years ago

M yupdate to redmine 2.3.3 seems to have fixed it.

Valkea commented 10 years ago

Hello, I have the same problem with Redmine 2.3.3.stable. I keep searching a way to fix this.

jume-dev commented 10 years ago

@cforce we recently fixed a bug, which prevented the activity from being set, when only having permissions to track time. maybe your error was caused from this?

@Valkeanaa please verify that you have the newest release and try to reproduce your problem on a fresh redmine. oh, and we haven't verifief that it works on redmine 2.3.3 yet. so maybe try it on 2.3.2

Valkea commented 10 years ago

@jume-dev Today, on top of Redmine 2.3.3, I also tried with Redmine 2.3.2 stable and Redmine 2.4.0 devel (I use the last redmine_time_tracker version), but I had the same problems with all versions.

1 - "Booking could not be added!" when I try to stop a clock, from whatever location 2 - On the TimeTracker page, the activity are in red color, and the stop button is disabled.

If I edit the current time tracker in the "time_trackers" table and change the "activity_id" to 1 instead of NULL, then I can stop the time tracker with any stop button on redmine. However it doesn't change anything on the TimeTracker page, the activity is still in red color and the stop button is still disabled.

Finally, if instead of starting the time tracker from an "Issue" page, I start it from the top right of from the TimeTracker page, then I can stop it without changing the "activity_id" in the database.

In short, times appearing in "Your time logs" works without problems, but times appearing in "Your time bookings" needs some "help" to stop.

I hope it will help. Until then, I will deactivate the plugin. Thank you

jume-dev commented 10 years ago

What permissions do you have?

Valkea commented 10 years ago

@jume-dev I gave full permissions (on the TimeTracker) to the Manager, Developer and Reporter roles. (And was set as Manager and Developer when I made tests with TimeTracker)

jume-dev commented 9 years ago

@Valkeanaa We made some changes to the whole updating and stopping stuff. Please check, if the problem still occurs.