search

hicommonwealth / commonwealth

A platform for decentralized communities
https://commonwealth.im
GNU General Public License v3.0
67 stars 44 forks source link

Infinite scroll should display a loading icon / bobber when you reach the bottom + the endpoint hasn't yet responded. #2877

Open jnaviask opened 1 year ago

jnaviask commented 1 year ago

Let's make Notifications Paginate with Scroll so we have an example for other lists that need scrolling.

CowMuon commented 1 year ago

Closing as won't fix, we can reopen if needed for Unified Profiles

jnaviask commented 1 year ago

I was wrong about this ticket -- the actual issue is pagination at the route level. This is still open.

masvelio commented 1 year ago

What Gabe had in mind here is this https://virtuoso.dev/endless-scrolling/

https://user-images.githubusercontent.com/14819225/227206529-5317885e-6a44-4894-be8b-16a4fe51ae3f.mp4

To make it work, we have to have pagination correctly implemented on the backend side. It is very nice UX pattern but I don't think this is our biggest concern now. Thus, I would treat this ticket as low-priority or even won't fix. This should be agreed with the design that this is what we want, and then have a plan to introduce this to the every list, and then this needs work on backend and then on the FE.

kurtisassad commented 1 year ago

Added needs spec because our back and front end don't support pagination for any of these pages other than getting threads. Also we have 3 APIs to get notifications. I have started to overhaul things, but if it is not crucial it can be postponed.

jnaviask commented 11 months ago

@masvelio @kurtisassad how would we feel about taking this ticket up again?

masvelio commented 10 months ago

needs investigation but it would need changes in: