hicommonwealth / commonwealth

A platform for decentralized communities
https://commonwealth.im
GNU General Public License v3.0
67 stars 41 forks source link

Add snapshot tests for login form component (empty, invalid, valid state) #3370

Open dillchen opened 1 year ago

dillchen commented 1 year ago

Acceptance Criteria:


Other related

1-2 points: Add snapshot tests for post editor component Acceptance Criteria:


End to End Testing 2-3 points: Discuss approach for mod tools testing Acceptance Criteria:

dillchen commented 1 year ago

cc: @jnaviask for discussion

jnaviask commented 1 year ago

Main thing to ask here is: what exactly does this test validate? The answer (per Chat GPT) is "Unexpected UI Regressions". Note that this is a very uncommon form of failure mode in my experience, and stringent snapshot tests can actually prevent essential UI changes from shipping, as the tests may need to be updated.

Instead, most failure cases involve (a) failed deployments (theoretically caught by integration tests) and (b) feature regressions (caught by unit/integration/e2e tests). UI regressions make sense to test for long term once we have a design system and proper prototypes/design documents for each of our components, but not essential in the near or medium term.