hicommonwealth / commonwealth

A platform for decentralized communities
https://commonwealth.im
GNU General Public License v3.0
68 stars 44 forks source link

Support Keplr on Injective #3883

Closed jnaviask closed 1 year ago

jnaviask commented 1 year ago

Description

High priority BD request.

Currently Injective only supports Metamask. However they are a Cosmos chain with an EVM layer, and requested Keplr support as well. Evmos already is a community that supports both options, but Injective requires a different signature scheme than them. We may need to do a little research on how to ensure we properly validate Keplr-produced signatures from Injective.

Acceptance Criteria

ianrowan commented 1 year ago

Image

Wanted to check if the logic here for !specificChains is correct or if this could be the bug. this is the only place I could find that uses the specificChains attribute and theoretically you cannot log into the homepage with any wallet whos IWebWallet has a specific chain.

Main question is should this be !specificChains.includes(chain) or something of that sort. When omitting this logic we end up with two keplr wallet login options, one for EVM and one for Cosmos. Is this how we would want the UX to be here or is this more complex? CC: @jnaviask

jnaviask commented 1 year ago

@ianrowan If I recall correctly, this case ("general case") is for determining which wallets we display on the homepage login screen or other unscoped pages. We do not want to surface wallets that are overly specific, otherwise the user would be overwhelmed with options. So it omits wallets that declare a specificChain from the list.