hicommonwealth / commonwealth

A platform for decentralized communities
https://commonwealth.im
GNU General Public License v3.0
67 stars 44 forks source link

Social Logins FFs: Replace wallet tags with social login tags #4125

Open zakhap opened 1 year ago

zakhap commented 1 year ago

Description

Using Magic Link for social logins on Common make it so Magic creates a "read-only" ethereum address for each social login (based on their email). To avoid adding complex business logic to our user experience, we don't want to display an address that has little to zero use minus as a means of recognizing a user.

Scenario 1: User logging in with a social login that is linked (same email match) The display name should default to their Common display name if they have one, if they don't, we will make their default display name their social login username in the universal top nav.

Thread post listing and Thread post page

Edit profile

Scenario 2: User logging in with a social login that is not linked (no email match) This is equivalent to user creation—and we will automatically make the user's display name the one in their Discord, Twitter, GitHub, and/or email address.

Thread post listing and Thread post page

Edit profile

Designs

userLoginTag

These tags appear next to display names in thread posts and thread post listings, replacing showing Magic-generated "read-only" addresses.

Thread feed Image

Thread post page Image

addressTag

These tags appear in the Edit profile page where we show all the linked addresses a user has. Instead of showing an address, we will show the same tag with the community icon, their social login username, and the addition of social icons from Phosphor (Twitter/Filled, GitHub/Filled, Discord/Filled, EnvelopeSimple/Regular, and Wallet/Regular).

Figma designs: Components and Patterns / Tags

Engineering Requirements

Acceptance Criteria

meeshlin commented 1 year ago

Ticket description added!

@jnaviask @MuonShot @zakhap @dillchen

zakhap commented 1 year ago

This has been bounced bc we don't have verified socials.

Blocked on: Magic Signatures from FE