Closed ianrowan closed 1 year ago
@dillchen thoughts on how non-template links should be shown in-line vs sidebar?
Realizing that templates are the only type of link that we create a component card for each link(other links are all contained in one card when multiple of the same type).
I guess what we need to scope out is:
@dillchen Checkout the POC here and lmk what you think. Currently working for Templates only b/c of the above points: https://www.loom.com/share/55567d3c30bb46fa9e132d49618c9268?sid=8c590f84-2c46-4e07-90ff-b83b9405b698
This LGTM. Great work.
It’s shippable as well.
We will circle back later on the UX of creation the sidebar and stuff via Omni Create so I think the drop-down to select display option is fine for now as well
Sent via Superhuman iOS @.***>
On Mon, Jul 24 2023 at 4:40 PM, Ian Rowan @.***> wrote:
@dillchen https://github.com/dillchen Checkout the POC here and lmk what you think. Currently working for Templates only b/c of the above points:
https://www.loom.com/share/55567d3c30bb46fa9e132d49618c9268?sid=8c590f84-2c46-4e07-90ff-b83b9405b698
— Reply to this email directly, view it on GitHub https://github.com/hicommonwealth/commonwealth/issues/4560#issuecomment-1648575830, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABIWMHLTXDCJFHGKWF2GRMTXR3MVVANCNFSM6AAAAAA2THFBDU . You are receiving this because you were mentioned.Message ID: @.***>
Description
Links on threads should have the ability to be toggled to show/hide + location. This will enable a customizable UI for any individual thread. Ideally the Link model can be extended with display options and a UI/UX included to toggle these links
Engineering Requirements
Threads.links
model includes adisplay
parameter per linkdisplay options
Acceptance Criteria