hicommonwealth / commonwealth

A platform for decentralized communities
https://commonwealth.im
GNU General Public License v3.0
67 stars 42 forks source link

Gating | Create + Edit Group page #4991

Closed zakhap closed 10 months ago

zakhap commented 1 year ago

Description

This form page is used both for creating and editing Groups information.

Requires: Groups API

DevLinks: https://www.figma.com/file/ePuGFatYQI6GL72i27sVwj/Gating?type=design&node-id=3-38&mode=design&t=YotqyxzZxIGCRSuK-0

Acceptance Criteria

Behaviors:

URLS:

Additional context

Screen Shot 2023-09-06 at 9 20 20 PM Screen Shot 2023-09-06 at 9 20 31 PM
jnaviask commented 1 year ago

@zakhap @jessmart1213 I suggest adding a big warning box of some sort to say that current group members will be cleared if requirements are edited for a group. This is because changing requirements mean we no longer know if an address which previously passed the set of requirements still passes given the new requirements, and also because we don't check all members upfront -- only when they visit the site. So, changing requirements clears the group.

mzparacha commented 1 year ago

Update the point label since it involves some more components to be created

jnaviask commented 11 months ago

@mzparacha let's make sure we get this page behind a feature flag so we can merge it while we work on the rest of the pages.

mzparacha commented 11 months ago

sure, sounds good @jnaviask

Just to confirm if we follow/use any labels for that?