Provide Basic Information About Community

sachben91 commented 10 months ago

User Story

When I attempt to create a community on Common, I should be provided with a form to enter the basic information about my community such as the name and a logo. When I create a name, it should be clear to me what the URL for my community will be. There should also be optional fields to add social links.

Product specs

[x] 1- Name of the community should be unique and does not have to be case-sensitive
[x] 2- URL for the community should be generated and displayed in the Community URL field. the URL has to take the community name and convert it into lowercase
[x] 3- Users should be able to select a chain from a dropdown. The ecosystem they select in step one will limit the options that they have here. For example, if they selected Ethereum then the option should be Mainnet by default and other EVM sidechains such as Polygon. If they select Cosmos ecosystem, then the drop down should have all the cosmos chains. The chain selection dropdown component from Related Communities can be reused here.
[x] 4- An exception here is Polygon, which is both shown as an ecosystem and a selection under "select chain". From a business side we are treating Polygon as an ecosystem so that when a user from Polygon is onboarding, they can click on Polygon in ecosystems and the chain should be pre-populated to Polygon in step two.
[x] 5- User should be able to select or drag and drop an image. The image sizes should remain the same as it is for the the current create community flow
[x] 6- Social links should be optional
[x] 7- User should have ability to add more than one social link by clicking on "add social link" that will generate another social link field
[x] 8- Description should be mandatory and not optional
No new components

Designs

Acceptance criteria

User should be able to add basic, necessary information about their community and finish creating a community on Common

dillchen commented 9 months ago

"User should be able to select or drag and drop an image. The image sizes should remain the same as it is for the the current create community flow"

Will the Image Component use the "Generate Image" functionality that should be available with existing component (using DALLE 2 / 3 - this is currently broken 405ing)

masvelio commented 9 months ago

@sachben91 Questions:

Let's go through questions from figma asked by engineers
There is no visual indication on which inputs are required vs which are optional.
What happens on clicking Cancel?
Buttons should be right aligned?

And I have also more technical questions so cc'ing @jnaviask but @sachben91 feel free to add your opinions as well

Is Select Chain field in designs the same as Base chain in current app? From the description it seems like it is not.
In current app depending on selected type of community, the form looks a bit different. Eg for Polygon we need to specify Token Contract Address, for Solana we need to specify Mint Address. Also we have Token Contract Address field for ERC20 and ERC721 (btw do we still support them?). My main question is that we probably would need some backend changes as well to support new flow for community creation and this would need additional investigation.
What is symbol in current create community form and why we do not need that in new implementation?

masvelio commented 9 months ago

Estimation is 5. The good thing is that we can reuse (probably with small tweaks) select image component and add social link component from edit profile page. There is also unknown what is happening with the backend. We need to rewrite the code responsible for sending data to the backend using react-query.

sachben91 commented 9 months ago

@sachben91 Questions:

Let's go through questions from figma asked by engineers

There is no visual indication on which inputs are required vs which are optional.

Will be added

What happens on clicking Cancel?

User goes back to the Select Community page. There should be a modal that confirms they want to do this - Design to add this

Buttons should be right aligned?

Will be done
And I have also more technical questions so cc'ing @jnaviask but @sachben91 feel free to add your opinions as well 5. Is Select Chain field in designs the same as Base chain in current app? From the description it seems like it is not. 6. In current app depending on selected type of community, the form looks a bit different. Eg for Polygon we need to specify Token Contract Address, for Solana we need to specify Mint Address. Also we have Token Contract Address field for ERC20 and ERC721 (btw do we still support them?). My main question is that we probably would need some backend changes as well to support new flow for community creation and this would need additional investigation. 7. What is symbol in current create community form and why we do not need that in new implementation?

kurtisassad commented 9 months ago

So we have an issue with the symbol. From old createCommunities:

The problem is we use this symbol to display currencies for snapshot. For example: https://commonwealth.im/redacted-cartel/snapshot/redactedcartel.eth/0xe2d2745f0f2254adab6bef62e8f11f302764d3e836f93b3b47e384439df68bf7

Here BTRFLY is displayed, due to it being the symbol for this community. Although Marcin suggested maybe we could add it to the admin panel., because maybe it is not super important for a starter community. Any thoughts @sachben91?

sachben91 commented 9 months ago

@kurtisassad Thanks for bringing up the issue around removing symbols. We will be adding this to admin capabilities when we do admin capabilities revamp which is teed up to be in early January

mzparacha commented 9 months ago

4- An exception here is Polygon, which is both shown as an ecosystem and a selection under "select chain". From a business side we are treating Polygon as an ecosystem so that when a user from Polygon is onboarding, they can click on Polygon in ecosystems and the chain should be pre-populated to Polygon in step two.

From what I understood, when "polygon" as an ecosystem is selected in step 1, we will only show a single option "Polygon" in "Select Chain" dropdown (plz lmk if wrong)

It will show up like this (notice the "Chain" dropdown)

An extra thing I have added here is to make the chain dropdown disabled, because based on my assumption we only display a single option in chain (when "polygon" as an ecosystem is selected) -- lmk if I should revert this extra change

Plz lmk if any issues. Thanks

cc: @sachben91 @masvelio

mzparacha commented 9 months ago

Some Questions:

Is the Image field mandatory?
Is there any specical structure of the URL in the "Community URL" field (for now I have made it origin/{community name} ex: https://commonwealth.im/myCommunity)
What is the min/max community name limit?
What is the min/max community description limit?
What is the max social links limit?
If the community name is already taken, which message should we display? For now I am displaying this

There are some comments from @dillchen regarding the image component

Will the Image Component use the "Generate Image" functionality that should be available with existing component (using DALLE 2 / 3 - this is currently broken 405ing)

Just confirming if we want to include the "generate image" functionality?

cc: @sachben91 / @masvelio

masvelio commented 9 months ago

Some Questions:

Is the Image field mandatory?

Is there any specical structure of the URL in the "Community URL" field (for now I have made it origin/{community name} ex: https://commonwealth.im/myCommunity)

What is the min/max community name limit?

What is the min/max community description limit?

What is the max social links limit?

If the community name is already taken, which message should we display? For now I am displaying this

There are some comments from @dillchen regarding the image component

Will the Image Component use the "Generate Image" functionality that should be available with existing component (using DALLE 2 / 3 - this is currently broken 405ing)

Just confirming if we want to include the "generate image" functionality?

cc: @sachben91 / @masvelio

Yes, it should be required (see schema)
We should reuse id builder that we have in current create community flow (see image below). Then we display community URL field as commonwealth.im/{id}
According to the schema it is max 255 characters, we do not have min limit.
According to the schema we do not have min/max limit.
According to the schema we do not have min/max limit.
This is aligned with the designs so yeah, this is good.
If generate image is plug & play without any additional work, we can do that. If this is extra work, we should not add it, as it was not in the scope. We can always add it to v2.

masvelio commented 9 months ago

From what I understood, when "polygon" as an ecosystem is selected in step 1, we will only show a single option "Polygon" in "Select Chain" dropdown (plz lmk if wrong)

This is correct.

An extra thing I have added here is to make the chain dropdown disabled, because based on my assumption we only display a single option in chain (when "polygon" as an ecosystem is selected) -- lmk if I should revert this extra change

From my perspective it is fine, but will default it to @sachben91

sachben91 commented 9 months ago

The extra change sounds good and the right way to do it. Thank you

mzparacha commented 9 months ago

Thank you for the feedback Sachin/Marcin. I also added another additional change, when image is uploading the "next" (form submit) button will be disabled

https://github.com/hicommonwealth/commonwealth/assets/51641047/bb038ed7-4246-43c5-ab4f-d48016f94ecc

mzparacha commented 9 months ago

The frontend side is done, I suggest we connect the API to the frontend in a separate ticket.

hicommonwealth / commonwealth