hicommonwealth / commonwealth

A platform for decentralized communities
https://commonwealth.im
GNU General Public License v3.0
67 stars 44 forks source link

Modal Select #5646

Closed sachben91 closed 10 months ago

sachben91 commented 11 months ago

Description

The modal select component is used in the Create Community flow. It gives the user the ability to connect a wallet or sign in using a method that is compatible with the ecosystem they selected. The options shown in this modal is limited by the selection that the user made in the select community type screen. The options available for each selection is shown in this figjam

Screenshot 2023-11-28 at 9 50 06 AM

Figma dev link

Behaviors

Image

Image

masvelio commented 11 months ago

@sachben91 Questions:

  1. The options shown in this modal is limited by the selection that the user made in the select community type screen.

Can we specify what exactly are those limitations and what/when they are applied to? So eg what is the difference when user picks Ethereum vs Cosmos vs Polygon vs Solana?

  1. If user is logged in and has only 1 address, do we still show address selector modal? image

  2. Sometimes I think like wallet and address are used interchangeably. Eg in Which wallet would you like to serve as the admin of the new community? or Connect New Wallet I feel like this should be address instead of wallet. But that's just my opinion.

  3. I think we talked some time ago with @jessmart1213 and agreed that buttons in modals should always be aligned to the right.

  4. I see potential issues in the flow, when the user is not logged in and has to do the sign in process via wallet or magic. For example, authentication with magic requires the app to be reloaded. Thus, I am not sure if that will be super easy to come back to the exact spot where the user left off during the community creation process. I am also not sure, if after signing in, the user should see address selection modal or should be redirected to [basic information page]?(https://github.com/hicommonwealth/commonwealth/assets/14819225/cd74765f-dd87-4e58-bb87-2c7242467536)

    address selection modal image

basic information page image

sachben91 commented 11 months ago

@sachben91 Questions:

  1. The options shown in this modal is limited by the selection that the user made in the select community type screen.

Can we specify what exactly are those limitations and what/when they are applied to? So eg what is the difference when user picks Ethereum vs Cosmos vs Polygon vs Solana?

  • Added the figjam to the ticket that shows what the difference is when user selects Ethereum vs Cosmos vs Solana
  1. If user is logged in and has only 1 address, do we still show address selector modal? image

    • Yes we should show it since we want them to confirm that they are using the right wallet
  2. Sometimes I think like wallet and address are used interchangeably. Eg in Which wallet would you like to serve as the admin of the new community? or Connect New Wallet I feel like this should be address instead of wallet. But that's just my opinion.

    • We should likely use 'address' instead of 'walet' everywhere to be consistent, but the above question needs further consideration for future projects, we shall make a note to do so.
  3. I think we talked some time ago with @jessmart1213 and agreed that buttons in modals should always be aligned to the right.

    • Will make this change
  4. I see potential issues in the flow, when the user is not logged in and has to do the sign in process via wallet or magic. For example, authentication with magic requires the app to be reloaded. Thus, I am not sure if that will be super easy to come back to the exact spot where the user left off during the community creation process. I am also not sure, if after signing in, the user should see address selection modal or should be redirected to [basic information page]?(https://github.com/hicommonwealth/commonwealth/assets/14819225/cd74765f-dd87-4e58-bb87-2c7242467536)

address selection modal image

basic information page image

sachben91 commented 10 months ago

@masvelio

image Copy for modal when user non signed in users and users who are signed in that want to connect a new wallet

Heading: Sign-in to create your community body text: To launch your community choose a sign-in option that is compatible with the ecosystem you selected.