hicommonwealth / commonwealth

A platform for decentralized communities
https://commonwealth.im
GNU General Public License v3.0
67 stars 44 forks source link

Signing in with different metamask wallets troubles. #6320

Closed cowballzach closed 9 months ago

cowballzach commented 9 months ago

Describe the bug

When doing QA I was instructed to test Gating Groups for Stargate. With a new metamask wallet and STG tokens I tried to connect my new wallet to my test commonwealth account. When trying to connect the new wallet, the metamask pop up requested to connect my main wallet address connected to my admin commonwealth account. There was no option to select secondary metamask accounts when trying to link a new metamask wallet.

Initial conditions

Environment:

Branch/Release version:

Browser:

Wallet:

Reproduction steps

On a new commonwealth profile, try to connect a new metamask wallet to that profile. The metamask prompt will opt for the user to connect their previously connected wallet instead of the new wallet with no option to switch.

Actual behavior

Expected behavior

I should be able to click or change what metamask wallet I want to be associated with what commonwealth account.

Screenshots / Video

https://www.loom.com/share/0555a42099b44fb0a1dcf6bef2b118ec?sid=a64a2f8a-81de-4287-88cc-5a0ce6d27459

Reporter

Growth - Rhys & Mitchy

Additional context

bug came up when growth was trying to do QA for https://github.com/hicommonwealth/commonwealth/issues/6301

jnaviask commented 9 months ago

@ianrowan feel free to consult with @mzparacha on this one, may be related to #5110

ianrowan commented 9 months ago

Cannot reproduce this. If both of my metamask accounts are selected as connected to CW then the address selected in MM is the one that is prompted to sign to add the new address.

I think we had a whole discussion about this same issue on a past ticket and came to the conclusion its a MM UX issue.

When trying to connect a new account the user is probably prompted with this:

image

Users often dismiss this, even though clicking connect is required to be able to user the selected MM address to connect/ sign

CC @jnaviask @cowballzach

ianrowan commented 9 months ago

To troubleshoot the exact issue in the ticket, you can follow these steps @cowballzach https://www.loom.com/share/9eb8cc9bdbc249cd821969fdb00f6edd

cowballzach commented 9 months ago

That worked for me. Thank you for the loom Ian!