[SPIKE-102] Self-managed "Growl"

hicommonwealth / commonwealth

A platform for decentralized communities

https://commonwealth.im

GNU General Public License v3.0

67 stars 44 forks source link

[SPIKE-102] Self-managed "Growl" #6809

Closed CowMuon closed 7 months ago

CowMuon commented 8 months ago

Description

Rather than asking Engineering to add interstitials to the app, Growth should be able to easily self-manage current active announcements to users.

Engineering Requirements

Per 6763](https://github.com/hicommonwealth/commonwealth/issues/6763

Enable / disable current growl
Update growl metadata (per above, "Growl concept" excepted)
Maintain a library of re-usable growls

Acceptance Criteria

Report of findings with execution plan attached here (or added to Engineering Spikes folder and linked here.)
Execution follows in #6810

Additional context

See #6763 Stake "Growl" for context
"Growl" is in quotes here since technically the interstitials we use are technically not growls.

masvelio commented 7 months ago

first version of spike is here https://docs.google.com/document/d/1nhvgFV0MoznIxjh6WsZ56PHG9_njqQF8VY2O8IAjNnA/edit
shared with growth team, waiting for some feedback

CowMuon commented 7 months ago

Not to throw a 🔧 into the works here, but JTN the growls we are using as currently implemented are less than optimal on mobile.

In fact we decided to deprecate the growl on mobile as it was taking up the entire screen and otherwise contributing to a sub-par experience.

Thus, whatever implementation we define needs to handle mobile accordingly. We haven't currently decided what that entails; the suggestion is made to use push notifications on mobile rather than a pop-up.

@masvelio for visibility

masvelio commented 7 months ago

before we go into implementation #6810 we should then think about new designs for mobile growl. Until the logic for showing/hiding them will be the same for desktop & mobile, we should be able to manage growls from one place in super-admin-panel for both platforms (this should actually be the goal).

@jessmart1213 @jabell88

masvelio commented 7 months ago

according to the design team, there is no capacity for design work on growl right now. We can close this spike ticket and the implementation ticket https://github.com/hicommonwealth/commonwealth/issues/6810 will be moved to the backlog with "needs design"