search

hicommonwealth / commonwealth

A platform for decentralized communities
https://commonwealth.im
GNU General Public License v3.0
67 stars 42 forks source link

Create Contest - Transaction Page (2/2) #7121

Closed zakhap closed 4 months ago

zakhap commented 6 months ago

Description

Similar to the Launch Stake page, this page enables users to launch stake by formatting the transaction and prompting the user to sign the transactions in multiple steps.

The first transaction deploys the Contests Contract. The second transaction, if the contest is recurring, updates the Fee Manager contract to divert stake fee to the contest deployed.

Mobile Designs: https://www.figma.com/file/NNqlhNPHvn0O96TCBIi6WU/Contests?type=design&node-id=222-5018&mode=design&t=jSWEbMsjeCOfz3od-0

Desktop Designs: https://www.figma.com/file/NNqlhNPHvn0O96TCBIi6WU/Contests?type=design&node-id=187-8370&mode=design&t=jSWEbMsjeCOfz3od-0

Project Owner

@zakhap @jaredbell

Engineering Requirements

Acceptance Criteria

Additional context

Screen Shot 2024-03-14 at 1 18 49 PM Screen Shot 2024-03-14 at 1 17 47 PM

NOTE: There might be a Third transaction step added later to this page that enables users to deposit funds directly to the contest deployed so that it can be funded effectively on day 1. This widget has not yet been confirmed so it is not included in this ticket. It will be a separate later ticket as the component will also be used in other places.

masvelio commented 5 months ago

@zakhap

  1. Can't see any tickets that will cover those three screens

If those screen are valid, we can extend scope of this ticket by those screen.

Fund you contest page

  1. What kind of addresses should we list in the dropdown Select address. Are those connected to this particular community? What if address does not have funds? Any error states?

  2. Also, we need some copy for error states for Amount field. Eg if user types more eth than he owns.

  3. We need general error state for failure after clicking Add funds to contest button.

  4. What's the deal with the drawer? Is this kind of PoC or we should implement it into the flow? Need more details here.

masvelio commented 5 months ago

estimation for components work for

  1. transaction page
  2. your contest is live
  3. fund your contest
  4. your funds transferred successfully

without backend integration and drawer => 3 points

masvelio commented 5 months ago

blocked by #7120

zakhap commented 5 months ago

Can't see any tickets that will cover those three screens

This page can be added as the next page after both transactions are successful. => good catch.

This page will not be implemented as we have the "Fund the contest" Drawer component instead.

This page will not be implemented as we have the "Successfulyl funded" view inside the Fund Drawer instead.

Screen Shot 2024-04-10 at 11 39 42 AM
zakhap commented 5 months ago

As for what addresses are to be shown in the Fund your Contest Drawer:

masvelio commented 5 months ago

Bumped down to 2 because fund your contest and your funds transferred successfully needs to be done in drawer ticket #7373