Fix infinite loop on Members page

hicommonwealth / commonwealth

A platform for decentralized communities

https://commonwealth.im

GNU General Public License v3.0

67 stars 42 forks source link

Fix infinite loop on Members page #7155

Closed rbennettcw closed 5 months ago

rbennettcw commented 6 months ago

When scrolling through the Members page of a community, too many requests are made in quick succession.

Steps to repro:

Go to http://localhost:8080/ethereum/members?tab=all-members
Scroll through members– observe that many network calls are fired

Video: https://github.com/hicommonwealth/commonwealth/assets/126922418/f5b42a1f-42a8-498a-aa3d-74eebe4f9cdc

Acceptance Criteria

When scrolling through the Members page, it should not make rapid network calls.

rbennettcw commented 6 months ago

Although it appears to be FE, I'm checking to see if the BE is sending duplicate profiles to the FE– which could cause rendering issues as shown in the video (multiple items with same key rendered in list).

rbennettcw commented 6 months ago

No dupes found in the backend payload for the profiles route. Wrote a script to go through 100 pages and check.

lzach83 commented 6 months ago

Moving this back to backlog until there's more clarity here.