hicommonwealth / commonwealth

A platform for decentralized communities
https://commonwealth.im
GNU General Public License v3.0
67 stars 44 forks source link

Turning off notifications should not show "Subscribed!" message #7406

Open Israellund opened 7 months ago

Israellund commented 7 months ago

Describe the bug

-When a user clicks the notifications icon they are shown a "Subscribed!" notification. But if they click it again to shut off the notification they are shown the same message

Reproduction steps

-go to any thread -subscribe to the thread by clicking the bell icon, notice the "Subscribed!" notification -click it again and notice the same notification

Actual behavior

-unclear notification

Expected behavior

-notification should reflect what is happening and give correct feedback

Screenshots / Video

https://github.com/hicommonwealth/commonwealth/assets/69872984/17b88df6-6346-496b-ba8e-bf90ce2ee0a9

CowMuon commented 7 months ago

Please be sure to surface any RCA as to how this got missed in the original implementation.