client side contest contract helpers

hicommonwealth / commonwealth

A platform for decentralized communities

https://commonwealth.im

GNU General Public License v3.0

65 stars 38 forks source link

client side contest contract helpers #7580

Closed ianrowan closed 1 week ago

ianrowan commented 2 weeks ago

Link to Issue

Closes: #7462

Description of Changes

Adds a client side helper to support Contest features including
- Creating Contests
- depositing into contests
Uses the design pattern of other helpers to initialize wallet correctly as well

Other Considerations

Deposit function requires 2 txs for ERC20 - approve and deposit. This may need design considerations and can be broken out in helper if necessary
Let me know if everything that needs to be supported protocol wise is here in initial review and I can add as necessary

ianrowan commented 2 weeks ago

Will leave this in draft until initial review tot check if requirements are met

Rotorsoft commented 1 week ago

@ianrowan just wondering if there are overlaps between /commonwealth/client/...contracthelpers and the ones we have in /libs/shared? ... ideally everything related to protocol helpers should be in one place (/libs/shared)

ianrowan commented 1 week ago

@Rotorsoft There isnt overlap here other then ABI's which I can look into merging.

Client helpers will probably need to stay in the client context because they use client side state(I'm not a frontend expert per say, but guessing this is true - using app.state) to manage wallet's etc. Transaction configurations through a wallet are also different than through a hosted private key and rpc which results in needing different implementations for client and platform