Closed mzparacha closed 2 weeks ago
cc: @masvelio
[X-posting a conversation from Slack]
Malik:. As we discussed yesterday that we want to have the ability to change tag names, what would be the nature of name change? Would it be like ex: original name -> Marketing , updated name -> Marketing/Business or ex: original name -> Marketing , updated name -> Gaming ?
Harris: As a general rule, I dont think that we should just change the name of a tag from one completely different subject to another. However, in the case where a tag exists and is unused - let’s say ‘anime’ and we want to change it to something in demand, I.e. ‘Solana’ then in my mind the run book would be to delete ‘anime’ and add a new tag for ‘Solana’ rather than edit and just change anime -> Solana.
But in the case where we need to edit the name of a given tag to make it better at communication, we should retain the ability to edit them. Lets say ex: original name -> Marketing , updated name -> Marketing/Business or or something like Gaming -> Solana-Gaming Memes -> Memes/Fun
Link to Issue
Closes: https://github.com/hicommonwealth/commonwealth/issues/7769
Description of Changes
Tags
table to store tags (ex:Defi
,DAO
,Marketplace
etc)ProfileTags
table to associate multiple tags to multiple profilesCommunityTags
table to associate multiple tags to multiple communities/updateProfile/v2
) to add/remove tags to the user's profile/profile/v2
) to return tags associated with the profile./updateCommunityCategory
) to add/remove tags to the community/communities
) to return tags associated with communitiesprofile/edit
) to use newer tags and allow user to add/remove those tags to/from profile/:communityId/manage/profile
) to add/remove tags to/from communityhttps://github.com/hicommonwealth/commonwealth/assets/51641047/2a320096-af7f-4d4a-adb4-3654e44b7ca6
"How We Fixed It"
N/A
Test Plan
yarn migrate-db
/:communityId/manage/profile
and scroll down to the "Tags" section, verify you see all the newly added tags and are able to add/remove them. Test this process with both navigate-back (submit the form, navigate to any other page, navigate back to this page) and page refresh.profile/edit
, scroll down to the "Preferences" section, and verify you see all the newly added tags and are able to add/remove them. Test this process with both navigate-back (submit the form, navigate to any other page, navigate back to this page) and page refresh.Deployment Plan
N/A
Other Considerations
The
category
column from theCommunities
table can be deprecated as we now have a newer way to store tags associated to communities. As this pr adds backward compatibility for storing community tags/category, i plan to do thecategory
column deprecation work in #7835