hicommonwealth / commonwealth

A platform for decentralized communities
https://commonwealth.im
GNU General Public License v3.0
64 stars 38 forks source link

User-Onboarding: Implemented Tags API + Integrated frontend #7824

Closed mzparacha closed 2 weeks ago

mzparacha commented 2 weeks ago

Link to Issue

Closes: https://github.com/hicommonwealth/commonwealth/issues/7769

Description of Changes

https://github.com/hicommonwealth/commonwealth/assets/51641047/2a320096-af7f-4d4a-adb4-3654e44b7ca6

"How We Fixed It"

N/A

Test Plan

Deployment Plan

N/A

Other Considerations

The category column from the Communities table can be deprecated as we now have a newer way to store tags associated to communities. As this pr adds backward compatibility for storing community tags/category, i plan to do the category column deprecation work in #7835

mzparacha commented 2 weeks ago
  1. ATM the only use case is to suggest communities that match user preferences, and that too during onboarding.
  2. It is not planned for user onboarding, I think. I did see a different Figma board 2/3 months ago where we had those new tags in the explore communities page, but again it was in a different feature work. Anyway if we try to do it here it would be scope creep and would delay this feature delivery which is planned for this week.

cc: @masvelio

HIM92 commented 2 weeks ago

[X-posting a conversation from Slack]

Malik:. As we discussed yesterday that we want to have the ability to change tag names, what would be the nature of name change? Would it be like ex: original name -> Marketing , updated name -> Marketing/Business or ex: original name -> Marketing , updated name -> Gaming ?

Harris: As a general rule, I dont think that we should just change the name of a tag from one completely different subject to another. However, in the case where a tag exists and is unused - let’s say ‘anime’ and we want to change it to something in demand, I.e. ‘Solana’ then in my mind the run book would be to delete ‘anime’ and add a new tag for ‘Solana’ rather than edit and just change anime -> Solana.

But in the case where we need to edit the name of a given tag to make it better at communication, we should retain the ability to edit them. Lets say ex: original name -> Marketing , updated name -> Marketing/Business or or something like Gaming -> Solana-Gaming Memes -> Memes/Fun