search

hicommonwealth / commonwealth

A platform for decentralized communities
https://commonwealth.im
GNU General Public License v3.0
67 stars 44 forks source link

Back out all uses of old notification system API calls. #8204

Closed burtonator closed 1 month ago

burtonator commented 3 months ago

Describe the bug

Right now if someone goes through onboarding they will use the old API calls for notifications.

Specifically:

      await app.user.notifications.disableSubscriptions(subs);
      await app.user.notifications.enableSubscriptions(subs);

we should track all uses of these down and make sure they are behind the same feature toggles as the rest of the application so that none of these are actually used once we push this out into production.

@mzparacha @sachben91

Initial conditions

Environment:

Branch/Release version:

Browser:

Wallet:

Reproduction steps

Actual behavior

Expected behavior

Screenshots / Video

Reporter

Additional context

mzparacha commented 3 months ago

Thanks @burtonator.

Self-note: newer notifications will only be used once knock is enabled.