hicommonwealth / commonwealth

A platform for decentralized communities
https://commonwealth.im
GNU General Public License v3.0
67 stars 42 forks source link

Weighted Voting for Farcaster Contests #8898

Closed sachben91 closed 1 week ago

sachben91 commented 3 weeks ago

Description

Farcaster contests need weighted voting as a contest voting mechanism. This was missed in the early iterations of Farcaster Contests. Weighted voting would enable admins of communities to set a token and corresponding vote weight for the token. Users on Farcaster who hold the token would be able to participate in the contest and add weighted upvotes to entries using Farcaster actions

Project Owner

No response

Bucket ID

No response

User Stories / Acceptance Criteria

Design Devlink

Figma designs

Design Screenshot

Screenshot 2024-08-19 at 1 46 09 PM

Additional Context

No response

masvelio commented 3 weeks ago

@sachben91 currently we have farcaster contest behind the feature flag. I am wondering if weighted voting will go on prod before, after or in the same time as farcaster. Introducing another feature flag would be problematic and make all those flows complicated. Can we assume that farcaster contest and weighted voting needs to go out together or they are independent?

sachben91 commented 2 weeks ago

@masvelio yes weighted voting using ERC20 and farcaster contests should go out at the same time cc @dillchen for awareness

masvelio commented 2 weeks ago
  1. Create topic page looks a lot different than currently. Just want to confirm if we want to change this view exactly how it is on the designs? Including parent topic dropdown and group permissions section? If yes, definitely to discuss with backend team as I think this might be a lift. I think we are missing details how this should work. image

  2. Is there a situation where weighted voting view is not available when creating a topic? Eg, this is only for communities that have stake enabled? image

  3. When the token banner should be displayed? I assume only for created topic that have weighted topic turned on?
    image

  4. Do we need any changes to "edit topic modal"? I mean, can we still edit/remove topics that will be using weighted voting? What happens with the content that belongs to the topic that is edited/deleted?

image

sachben91 commented 2 weeks ago
  1. Create topic page looks a lot different than currently. Just want to confirm if we want to change this view exactly how it is on the designs? Including parent topic dropdown and group permissions section? If yes, definitely to discuss with backend team as I think this might be a lift. I think we are missing details how this should work.
    • The only change here should be adding the tabbing at the top, the other changes are not part of this workflow and we should retain the page as is
  2. Is there a situation where weighted voting view is not available when creating a topic? Eg, this is only for communities that have stake enabled?
    • TBD but as per our discussion weighted voting should be available for everyone when creating a topic
  3. When the token banner should be displayed? I assume only for created topic that have weighted topic turned on?
    • token banner should be only for topics that have weighted voting enabled
  4. Do we need any changes to "edit topic modal"? I mean, can we still edit/remove topics that will be using weighted voting? What happens with the content that belongs to the topic that is edited/deleted?
    • do we allow users to delete topics that have contests at the moment @masvelio ? That is the only case in which deleting a topic presents a risk I think.
masvelio commented 2 weeks ago

@sachben91 yeah, we do allow removing topic. We disabled removing thread contest but topic is still deletable

masvelio commented 1 week ago

@sachben91 most of the UI has been done in this ticket https://github.com/hicommonwealth/commonwealth/issues/8981 Moreover, some of the requirements are not up-to-date. Imo we should close this ticket and keep working on this one as it has mostly the same scope + more up to date info. If you agree @sachben91, please close it

sachben91 commented 1 week ago

closed as per above comment