hicommonwealth / commonwealth

A platform for decentralized communities
https://commonwealth.im
GNU General Public License v3.0
67 stars 44 forks source link

Deprecate Unused Routes post lazy loading changes #8995

Closed mzparacha closed 2 weeks ago

mzparacha commented 1 month ago

Description

As part of #4976 we made several PRs that deprecate some old routes. These routes are

  1. /bulkOffchain

  2. /communities?active=true i.e this codepath and all its files https://github.com/hicommonwealth/commonwealth/blob/b11d90b7aca8664e144dab4a5f6de325bc0d6e68/packages/commonwealth/server/routes/communities/get_communities_handler.ts#L31-L36

  3. /communities i.e this codepatrh and all its files https://github.com/hicommonwealth/commonwealth/blob/b11d90b7aca8664e144dab4a5f6de325bc0d6e68/packages/commonwealth/server/routes/communities/get_communities_handler.ts#L52-L54

IMP: while removing 2 and 3 we have to be careful about not removing the search endpoint for communities i.e

https://github.com/hicommonwealth/commonwealth/blob/b11d90b7aca8664e144dab4a5f6de325bc0d6e68/packages/commonwealth/server/routes/communities/get_communities_handler.ts#L39-L50

or another option is that we support community searching via the new get communities trpc route (preferred).

Engineering Requirements

jnaviask commented 1 month ago

@mzparacha looks like we still use the FETCH_ACTIVE_COMMUNITIES endpoint throughout the codebase? Marking as blocked until I can understand how we can deprecate if the endpoint is still in use.

mzparacha commented 1 month ago

I will be removing it in https://github.com/hicommonwealth/commonwealth/issues/8966 before standup tomorrow. @jnaviask

Edit: PR here https://github.com/hicommonwealth/commonwealth/pull/9004

jnaviask commented 1 month ago

Dupe per above comment.

mzparacha commented 4 weeks ago

Actually @timolegros removed 2 in #9047, 1 and 3 still exist in the codebase.

cc: @jnaviask