hicommonwealth / commonwealth

A platform for decentralized communities
https://commonwealth.im
GNU General Public License v3.0
67 stars 44 forks source link

Editor design questions v2.. #9222

Open burtonator opened 1 week ago

burtonator commented 1 week ago

Describe the bug

OK. Another batch of UI questions for the editor.

Button in Footer

I need some guidance of how to handle the button in the footer. Our design TRD had the button in the footer.

Here's what it looks like per the TRD.

https://github.com/hicommonwealth/commonwealth/issues/8593#issuecomment-2307641913

However we have an issue because our buttons differ from desktop and mobile in the designs.

Here is what the footer looks like for desktop and mobile:

desktop

CleanShot 2024-09-17 at 13 53 59@2x

mobile

CleanShot 2024-09-17 at 13 54 14@2x

If we want the button in the footer, I can do that but I have to wrap it in another component to adapt its UI for desktop or mobile and add the functionality we need on mobile (different button) and support the ability to disable it in certain situations as needed by the 'new thread' page.

I don't really feel strongly on any of these issues so whatever you guys decide is fine with me.

Current UI

This is what it currently looks like:

CleanShot 2024-09-17 at 13 51 06@2x

Initial conditions

Environment:

Branch/Release version:

Browser:

Wallet:

Reproduction steps

Actual behavior

Expected behavior

Screenshots / Video

Reporter

Additional context

sssssabinaaa commented 4 days ago

-let's do full height for the desktop editor -let's also do a blue outline -if possible, adapt consistent style from the desktop footer to the mobile footer