hicommonwealth / commonwealth

A platform for decentralized communities
https://commonwealth.im
GNU General Public License v3.0
67 stars 44 forks source link

Connect routes for email notifications #9415

Open sachben91 opened 3 weeks ago

sachben91 commented 3 weeks ago

Description

On Knock, we have two types of emails we want to send:

Here are the workflows on Knock:

we have routes set up for these emails already but they need to be connected to the email templates

Project Owner

@sachben91

Bucket ID

No response

User Stories / Acceptance Criteria

Design Devlink

No response

Design Screenshot

No response

Additional Context

No response

dillchen commented 3 weeks ago

tagged @timolegros per parking lot, fingers crossed re template working as expected

timolegros commented 3 weeks ago

Issues:

  1. What is the default avatar URL for users who don't have one set?
  2. The Recap email template (and therefore likely also the digest email template) does not render correctly at all in email clients (just tested Gmail): Image Image Image

This issue requires extensive PENG work to get the email templates to render correctly according to designs/product spec.

timolegros commented 4 days ago

@dillchen why did you move this into review? Have the emails been made fully responsive using both routes? Unless I am mistaken we still need someone internal (e.g. Kevin) to link the routes to the templates to properly load the dynamic data.

Also, avatars won't work in emails until #9570 is finalized.