Update designs for user onboarding and admin cards

hicommonwealth / commonwealth

A platform for decentralized communities

https://commonwealth.im

GNU General Public License v3.0

68 stars 44 forks source link

Update designs for user onboarding and admin cards #9925

Open sachben91 opened 1 week ago

sachben91 commented 1 week ago

Description

The admin and user onboarding cards should be updated to the following design that reduces white space and adds a light blue background.

background color: #e5f1ff

Project Owner

@sachben91

Bucket ID

No response

User Stories / Acceptance Criteria

admin and user onboarding cards updated to the new design

Design Devlink

Figma

Design Screenshot

No response

Additional Context

No response

Israellund commented 4 days ago

@sachben91 Please confirm this is correct. The image above shows a red circled area, which Kaleem changed in another ticket, but I interpreted the user onboarding and admin cards to be the cards under "Welcome to Common" and "Finish setting up your community" (surrounded in blue in the image above). Please correct me if I'm wrong. And @KaleemNeslit For now, please don't close any tickets. If you think a ticket needs to be closed please let me know. Thank you.

KaleemNeslit commented 3 days ago

@sachben91 Please confirm this is correct. The image above shows a red circled area, which Kaleem changed in another ticket, but I interpreted the user onboarding and admin cards to be the cards under "Welcome to Common" and "Finish setting up your community" (surrounded in blue in the image above). Please correct me if I'm wrong. And @KaleemNeslit For now, please don't close any tickets. If you think a ticket needs to be closed please let me know. Thank you.

@Israellund in attached figma link there is not other cards then this . from now on you will merge my PR.

Israellund commented 3 days ago

@KaleemNeslit No, you will continue to merge your own PRs. I am just asking you to not close any tickets without getting confirmation that the ticket no longer needs work. Sometimes there is not one source of truth and you may be closing the ticket with work still needing to be done. For example, this ticket mentions "User onboarding and Admin cards" in the title, yet the Figma shows something different. That is why I tagged @sachben91 to confirm. The component you already changed to blue is called VoteWeightModule.tsx, yet nowhere in the description does it mention Vote Weight. I may be wrong and this ticket no longer needs to be done, but I am asking for confirmation before I close it.

KaleemNeslit commented 3 days ago

@KaleemNeslit No, you will continue to merge your own PRs. I am just asking you to not close any tickets without getting confirmation that the ticket no longer needs work. Sometimes there is not one source of truth and you may be closing the ticket with work still needing to be done. For example, this ticket mentions "User onboarding and Admin cards" in the title, yet the Figma shows something different. That is why I tagged @sachben91 to confirm. The component you already changed to blue is called VoteWeightModule.tsx, yet nowhere in the description does it mention Vote Weight. I may be wrong and this ticket no longer needs to be done, but I am asking for confirmation before I close it.

@Israellund thanks ! sure man