hicommonwealth / commonwealth

A platform for decentralized communities
https://commonwealth.im
GNU General Public License v3.0
68 stars 44 forks source link

[Launchpad Discovery]: Token Trade From Explore Page - Sell Mode #9926

Closed mzparacha closed 1 week ago

mzparacha commented 1 week ago

Link to Issue

Closes: https://github.com/hicommonwealth/commonwealth/issues/9892

Description of Changes

Added ability to sell tokens from the explore page.

"How We Fixed It"

N/A

Test Plan

  1. Create a new token
  2. Visit the explore page and attempt to buy that token, verify the pricing is correct
  3. Once you have some tokens bought, head over to the sell tab and attempt to sell some of those tokens
  4. Verify the token amount you enter correctly translates into eth amount per that token pricing
  5. Verify you are able to see receipt details correctly, verify the pricing data is correct
  6. Verify you are able to sell the token successfully
  7. Verify the modal closes after the token is sold successfully

Deployment Plan

N/A

Other Considerations

N/A

mzparacha commented 1 week ago

Re: https://github.com/hicommonwealth/commonwealth/pull/9926#pullrequestreview-2442368693

  1. query wasn't getting recalled even tho I added cache invalidation. fixed now.
  2. the hidden scrollbar was causing 8px diff, fixed now.
  3. fixed.
  4. same as 1, query needed a refresh, fixed now.

Thanks for the review @masvelio