one-or-more (zero-or-more atom) is wrong

hicsail / constellation-js

Library for combinatorially specifying, constraining, and exploring genetic design spaces.

http://constellationcad.org

MIT License

10 stars 8 forks source link

one-or-more (zero-or-more atom) is wrong #73

Closed dany-fu closed 4 years ago

dany-fu commented 5 years ago

xin-cao commented 5 years ago

I fixed the visual for this in terms of how it is represented in stateGraph. Can't confirm if this is the desired graph but at least there isn't a phantom node pointing to the epsilon node anymore: Screen Shot 2019-07-24 at 4 18 08 PM

dany-fu commented 5 years ago

I think one-or-more(zero-or-more) just means zero-or-more? So if we wanted to make the condensed visualization, there just shouldn't be a phantom edge. Regardless, I don't want to bandage the bug because if the underlying graph is wrong then the SBOL will be wrong

dany-fu commented 4 years ago

@vidyaap @xin-cao can we close this?

dany-fu commented 4 years ago

this is fixed by the simplification rules