search

hicsail / ionic-hockeyapp

Need HockeyApp in your Ionic application, add this package!
MIT License
18 stars 7 forks source link

Wrong Typings for hockey app #14

Closed junalmeida closed 6 years ago

junalmeida commented 6 years ago

Current version of cordova-plugin-hockeyapp have the following js signature:

var hockeyapp = {
start: function(success, failure, appId, autoSend, checkForUpdateMode, ignoreDefaultHandler, createNewFeedbackThread, loginMode, appSecret) {

The typings of your module have:

    start(androidAppId: string, iosAppId: string, sendAutoUpdates: boolean, ignoreErrorHeader: boolean): Promise<any>;

I guess that this is not matching

junalmeida commented 6 years ago

Closed because you implement abstraction over official sdk