hidakatsuya / action-setup-redmine

This action installs Redmine and sets up an environment to run tests. It is primarily aimed at providing an environment to run tests for Redmine plugins.
MIT License
1 stars 1 forks source link

Support Redmine 4.2 installation with handling blankslate gem #6

Closed sanak closed 2 months ago

sanak commented 3 months ago

Related with the following blankslate gem issue for Redmine 4.2,

I tried to setup custom Gemfile.local after this action's setup and a plugin's checkout,

but I encountered the following error from the last step in this action.

I am thinking to create PR for blankslate gem handling code inside this action, but is this the right direction ?

Other possibility is deleting the last Set up database step from this action and handling the step in this action's client (=plugin) side, but I think that it requires another client side modification.

sanak commented 3 months ago

Sorry, the error cause was not the last step, but ruby setup part from local investigation (https://github.com/sanak/action-setup-redmine/pull/1). 🙇💦 So, removing the last step is no meaning. I will create PR to support Redmine 4.2.

hidakatsuya commented 3 months ago

Sorry for the late reply. Furthermore, thank you for your report, investigation, and suggestions. I'll check your pull request.

sanak commented 3 months ago

Okay, no problem. Thanks a lot! 🙇