search

hidakatsuya / redmine_default_custom_query

Redmine plugin for setting default custom query of Issues for each project
http://www.redmine.org/plugins/redmine_default_custom_query
MIT License
73 stars 20 forks source link

Project settings #43

Closed picman closed 5 years ago

picman commented 5 years ago

A solution for #42.

maeda-m commented 5 years ago

Please refer to #37 .

picman commented 5 years ago

I'm sorry but I don't understand your objections to my patch. the super is the problem? Why? If I'm overriding a method from a class, calling super is a standard way how use the original method. Of course, you can reject the patch but the plugins will remain in conflict then.

maeda-m commented 5 years ago

I agree that using super is the standard way to override class methods.

However, since ProjectsHelper is a module, I think it is incorrect to use super.

ahorek commented 5 years ago

@maeda-m I think there should be a Module#prepend instead of ProjectsController.send :helper ?

here'a an article about the difference https://www.justinweiss.com/articles/rails-5-module-number-prepend-and-the-end-of-alias-method-chain/

maeda-m commented 5 years ago

Thank you. I learned from you. Released version 1.5.0 !