Support host os independent timezone db

hiddeco / cronjobber

Cronjobber is a cronjob controller for Kubernetes with support for time zones

Apache License 2.0

244 stars 38 forks source link

Support host os independent timezone db #10

Closed mterron closed 5 years ago

mterron commented 5 years ago

This commit adds support for independently maintaining an up-to-date timezone database as per #9

It adds requirements of internet access for the cronjobber-updatetz image to download updated files. The cronjobber-updatetz support standard proxy env variables.

hiddeco commented 5 years ago

Changes look good on digital paper, need to give it real spin though, which I will do tonight or tomorrow. Thanks so far :tulip:

mterron commented 5 years ago

There are a couple of env variables that might be useful to document:

TZPV is the location where the persistent volume for the timezone database is mounted on the updatetz container. (/tmp/zoneinfo by default)
REFRESH_PERIOD is how often the updatetz container will look for updates (1 week by default).

This is what a running instance log looks like (REFRESH_INTERVAL set to 30s for demo purposes):

2019-05-08T02:12:44+0000 Local Time Zone database updated to version 2019a on /tmp/zoneinfo
2019-05-08T02:13:15+0000 Local Time Zone database is up to date
2019-05-08T02:13:46+0000 Local Time Zone database is up to date

hiddeco commented 5 years ago

@mterron I see you made a couple more changes, what is the current state of this PR? Is there anything you need help with?

mterron commented 5 years ago

It is as generic as I can make it (all the latest commits removed things that work in my specific environment but not in a default installation). Please take it for a spin and see if it works for you.

On Fri, 10 May 2019, 02:21 Hidde Beydals, notifications@github.com wrote:

@mterron https://github.com/mterron I see you made a couple more changes, what is the current state of this PR? Is there anything you need help with?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hiddeco/cronjobber/pull/10#issuecomment-490925323, or mute the thread https://github.com/notifications/unsubscribe-auth/ABB2XW7JO3NPJFYCSDQYIXLPUQXOPANCNFSM4HK4LR3Q .

hiddeco commented 5 years ago

@mterron failing CI is not related to the content of my changes, a Google server is having issues.

Please take a look at the changes I made, if they look alright to you I will smash a couple of commits together to keep the master history clean and merge it. :sun_with_face:

I am interested in if the modified securityContext config is still failing on OpenShift by the way, so if you have some time to look into this that would be awesome.

hiddeco commented 5 years ago

Thanks again for your contribution. I have put out releases of both images, as soon as 0.2.0 has been pushed to the registry, kubectl apply -f https://raw.githubusercontent.com/hiddeco/cronjobber/master/deploy/deploy-updatetz.yaml should do the job.