search

hiddeco / cronjobber

Cronjobber is a cronjob controller for Kubernetes with support for time zones
Apache License 2.0
244 stars 38 forks source link

depracted apiversion for kubernetes 1.21 #49

Open mehmetyazicioglu opened 2 years ago

mehmetyazicioglu commented 2 years ago

Hello @hiddeco

is it okay to upgrade apiversions for clusterrole and clusterrolebinding due to kubernetes version upgrade.

The rbac.authorization.k8s.io/v1beta1 API version of ClusterRole, ClusterRoleBinding, Role, and RoleBinding is no longer served as of v1.22.

Migrate manifests and API clients to use the rbac.authorization.k8s.io/v1 API version, available since v1.8. All existing persisted objects are accessible via the new APIs No notable changes

https://kubernetes.io/docs/reference/using-api/deprecation-guide/

I think there is no harm for anyone if we change the apiversions since "Migrate manifests and API clients to use the scheduling.k8s.io/v1 API version, available since v1.14."

what do you think?

mehmetyazicioglu commented 2 years ago

@hiddeco pls review

mehmetyazicioglu commented 2 years ago

@hiddeco could you please review?