search

hiddeco / cronjobber

Cronjobber is a cronjob controller for Kubernetes with support for time zones
Apache License 2.0
244 stars 38 forks source link

CronJobber spinning up infinite jobs and pods on error #54

Open pabrahamusa opened 2 years ago

pabrahamusa commented 2 years ago

First of all thanks for this awesome component. While official Kubernetes is expecting to add a Timezone soon but it is getting delayed a lot and we are using CronJobber which works great.

I am using EKS 1.21 and noticed an issue where CronJobber cronjobs will keep spinning up new pods if there are any error, or ImagePullBackoff , CrashLoopBack etc.. it is not honoring the fields concurrencyPolicy: Forbid . This works well with default CronJob API i.e. apiVersion: batch/v1 but not with CronJobber apiVersion: cronjobber.hidde.co/v1alpha1.

Is it possible to add a fix for this I am assuming this is happening because of the updates on CronJob in v 1.20

apiVersion: cronjobber.hidde.co/v1alpha1 kind: TZCronJob metadata: creationTimestamp: "2022-05-18T20:02:02Z" generation: 19 labels: app: cronjob-test-qa chart: test-cronjobs-68 release: cronjob-test-qa name: cronjob-test-qa namespace: qa resourceVersion: "600673922" uid: 667b2f60-02a9-4d19-992a-9b0dba7e8d50 spec: concurrencyPolicy: Forbid failedJobsHistoryLimit: 1 jobTemplate: metadata: labels: app: cronjob-test-qa spec: backoffLimit: 2

hiddeco commented 2 years ago

I can not (with good conscious) release any of the proposed patches at the moment as I have no bandwidth to confirm they're working properly. Given this, feel free to e.g. attempt to build from https://github.com/hiddeco/cronjobber/pull/53 and use this at your own risk. But I fear that from my side, this project is very much abandoned as shared earlier in https://github.com/hiddeco/cronjobber/issues/43#issuecomment-890097573.