search

hiddenSymmetries / booz_xform

Calculates Boozer coordinates for toroidal MHD equilibria, including stellarators and tokamaks.
https://hiddensymmetries.github.io/booz_xform/
BSD 2-Clause "Simplified" License
11 stars 3 forks source link

plots.py. update attribute names #5

Closed panosz closed 3 years ago

panosz commented 3 years ago

This PR attempts to fix issue #4 assuming it is due to d6882133762312aefa7c3cfd50ec081adf2c8998.

It seems that although some attributes of the Booz_xform class where renamed in the commit mentioned above, the plots.py submodule had not been updated accordingly.

landreman commented 3 years ago

Hi @panosz , thanks for your interest and contributions. If you don't mind my asking, what's your name and what research are you working on with this code?

You're correct that issue #4 was due to this place in wireplot where I forgot to change p to nu. However there is actually also a sign flip: nu in this package corresponds to -p in the old fortran package. I just pushed a fix. If you compare the wireplot figures with the 2 sign options, especially for a low aspect ratio case like li383_1.4m, it can be seen that the black and red meshes (vmec coords and boozer coords) only align for the choice of sign in 821f4a0693a59756d91b1693d0485409d97bbedc.

panosz commented 3 years ago

@landreman , I certainly don't mind. In fact I have been meaning to contact you as well. I have sent you an email describing my research interests in general and my interest in your code in particular.

Is this sign flip that you mentioned the one described in the documentation?

landreman commented 3 years ago

Right, the sign flip is related to the Note in that documentation section.

Closing this PR since issue #4 is resolved by 821f4a0693a59756d91b1693d0485409d97bbedc.