Cmake hotfix - Githubissues

hiddenSymmetries / virtual-casing

4 stars 7 forks source link

Cmake hotfix #10

Closed smiet closed 1 year ago

smiet commented 1 year ago

Updated CMake flag handling (old version overwrote CXX flags, instead of appending)
updated pybind11 submodule for compatibility with python11 (as was done in simsopt here: https://github.com/hiddenSymmetries/simsopt/commit/8e7a0dbbdb3958c838172d80a56af8cd1471effd)

smiet commented 1 year ago

The mac wheel builder fails because of

Could NOT find OpenMP_C (missing: OpenMP_C_FLAGS OpenMP_C_LIB_NAMES)

The system setup step in the container gives:

 Warning: libomp 17.0.1 is already installed and up-to-date.
To reinstall 17.0.1, run:

so maybe the build prereqs need to be updated? Unlikely to be caused by my changes. @landreman is it you I should go to for mac-related stuff? could you have a look? (probably a quick fix for you).

landreman commented 1 year ago

It looks like the wheel builder CI hasn't ever worked for mac - the Could NOT find OpenMP_C error isn't new. Since that's an orthogonal issue, this PR looks good to me.