search

hiddenglovework / gloveworks_screenshot_bot

I have autism
0 stars 1 forks source link

Bash Script Is Unrefined #3

Open hiddenglovework opened 1 year ago

hiddenglovework commented 1 year ago

https://github.com/hiddenglovework/gloveworks_screenshot_bot/blob/0a261af221ea140ba5bbca2d45d166070820c3ee/run.bash#L1-L4

  1. Bash script should not require people to modify the contents. It should read from a hidden file ".token" that people can drop their token into it without assigning a variable (also create a .gitignore so no one can ever check in their API token accidentally)
  2. Use getopt to pass in arguments if needed
  3. Allow the ability to also pass in channel id so Glovework can move the bot to different channels if necessary
hiddenglovework commented 1 year ago

https://github.com/hiddenglovework/gloveworks_screenshot_bot/blob/0a261af221ea140ba5bbca2d45d166070820c3ee/build.bash#L1-L6

Getopt enhancement should be done in this script as well