search

hiddenswitch / ComfyUI

A powerful and modular stable diffusion GUI with a graph/nodes interface.
GNU General Public License v3.0
30 stars 10 forks source link

Specify torch versions to allow for pip install of this repo #1

Closed kenning closed 6 months ago

kenning commented 8 months ago

Hi there, I found your repo and have been using it to run comfyui nodes as code. It's very helpful!

For some reason though, when I was pip installing your repo on baseten, it would install a nightly build of torch 2.3.0 compiled for CPU. No idea why this was the case... Anyway by specifying the version of torch, vision and audio it fixed the issue. I thought this might solve a headache for other people trying to do the same thing, although it looks like you've been wrestling with these issues for a while so maybe this isn't too helpful. Who knows though.

Also, weird coincidence: I also made a 'community created card game.' It was collective.gg if you ever heard of it. Nice to meet you :smile:

doctorpangloss commented 7 months ago

Hi Nick - I am a big fan of Collective and well aware of your work. I am investigating baseten specifically because I make certain assumptions about how to detect CUDA and ROCm capabilities that seemed to have failed on its platform. Your patience is appreciated. Adding the versions resolves your issues by correctly detecting the torch preinstalled in their environment, which is another thing I am trying to address.

doctorpangloss commented 6 months ago

I added to the README how to install on platforms that have already installed torch . I have added additional code that checks what version of torch is installed and trusts it.

# You will need wheel without build isolation
pip install wheel
pip install --no-build-isolation git+https://github.com/hiddenswitch/ComfyUI.git

This should resolve your issues, it does for me.

kenning commented 6 months ago

thanks! may try this out at some point.