search

hiddentao / fast-levenshtein

Efficient Javascript implementation of Levenshtein algorithm with locale-specific collator support.
MIT License
596 stars 56 forks source link

Method signatures #13

Closed icodeforlove closed 8 years ago

icodeforlove commented 8 years ago

What are thoughts on changing the naming convention?

get(str1, str2);
get(str1, str2, callback); // which replaces getAsync by arguments.length == 3

This would make it more compatible with something like promisification.

hiddentao commented 8 years ago

Good idea. Will do now.

hiddentao commented 8 years ago

Done. Pushed v2 with a slight performance update.