search

hiddentao / gulp-server-livereload

Gulp plugin to run a local webserver with livereload enabled via socket.io. Also comes with standalone command-line interface.
MIT License
93 stars 28 forks source link

how to define rule when fallback should work? #37

Closed aafeltowicz closed 8 years ago

aafeltowicz commented 8 years ago

Is it possible out of the box to define rule when fallback should work?

What I want to achieve is to handle angular routes (SPA without hashbang) with fallback mechanism, but for missing static files I want to receive HTTP 404.

hiddentao commented 8 years ago

No support out of the box at the moment. But it sounds like a good idea. PR welcome.

aafeltowicz commented 8 years ago

Please find in attachment fix for my case.

no_fallback_for_static_files.zip

aafeltowicz commented 8 years ago

Any chance to commit changes and release new version?

hiddentao commented 8 years ago

If you could do it as a PR will be happy to include it. That way I will also be able to give feedback and we will be able to iterate on it if necessary.

aafeltowicz commented 8 years ago

Ok, my bad - sorry, I'm new to GitHub. PR done.

aafeltowicz commented 8 years ago

Thanks for merge. I've noticed that options table - (https://github.com/hiddentao/gulp-server-livereload#options) has broken after adding fallbackLogic param description.

hiddentao commented 8 years ago

Thanks, now fixed.

--  Ramesh Nair

Director HiddenTao Ltd (UK company no. 6807289)

http://hiddentao.com https://github.com/hiddentao https://www.linkedin.com/in/hiddentao

On 27 July 2016 at 11:56:07, aafeltowicz (notifications@github.com) wrote:

Thanks for merge. I've noticed that options table - (https://github.com/hiddentao/gulp-server-livereload#options) has broken after adding fallbackLogic param description.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.