search

hiddentao / gulp-server-livereload

Gulp plugin to run a local webserver with livereload enabled via socket.io. Also comes with standalone command-line interface.
MIT License
93 stars 28 forks source link

no fallback for static files #39

Closed aafeltowicz closed 8 years ago

aafeltowicz commented 8 years ago

PR for #37 fix.

hiddentao commented 8 years ago

This fix seems to be for a specific configuration of the fallback mode. It would be better if this were generally configurable.

I would prefer if we added a new fallbackLogic config param which defaulted to the else condition you currently have. But users would be able to override it to provide their own fallback logic.

aafeltowicz commented 8 years ago

I've added fallbackLogic param as you suggested, hope it's flexible enough now.

hiddentao commented 8 years ago

Thanks!