hiddentao / react-native-modal-filter-picker

Cross-platform modal picker for React Native which supports keyword filtering, custom rendering, etc
MIT License
104 stars 74 forks source link

Warning: Failed prop type: The prop `onRequestClose` is marked as required in `Modal`, but its value is `undefined`. #11

Closed Harryki closed 6 years ago

Harryki commented 6 years ago

Hello friends.

Thanks for the awesome picker library.

just tried your example on my project and encountered this warning message

any thought about this?

Harryki commented 6 years ago

i added onRequestClose={this.props.onRequestClose} property in component in line 47 and passed property onRequestClose in my .

you can close this issue.

ducanhmai205 commented 6 years ago

i cant fix this issue, can u give more infomation abt this pls

clems36 commented 6 years ago

I have the same issue. Harryki fixed the warning by adding onRequestClose={this.props.onRequestClose} in the index.js of the library at line 47. Can you implement it please ?

daleshaney commented 6 years ago

I tried to implement the fix given by Harryki, however I still get the error, even after putting onRequestClose={this.props.onRequestClose} in the index.js of the library at line 47. Is there something I am missing to fix this?