search

hiddentao / react-native-modal-filter-picker

Cross-platform modal picker for React Native which supports keyword filtering, custom rendering, etc
MIT License
104 stars 74 forks source link

onChangeTextProp #26

Open mbyram1 opened 5 years ago

mbyram1 commented 5 years ago

This PR is designed to allow for consumers of this component to get the value of the text being entered. The use case for this is to allow for users to search their api to reload data on longer lists.

hiddentao commented 5 years ago

Good idea, but I think it needs architecting a little differently. If user wishes to manually filter then the built-in filtering should be turned off for that.

nihp commented 4 years ago

@hiddentao Are you maintaining this library or not. Can you change or make any appropriate actions for this.

Thanks

hiddentao commented 4 years ago

@nihp See my previous comment. On this, since the modal already has built-in filtering we'd need to do some work to ensure that's disabled when custom filtering is enabled.