Refactored to use FlatList in place of deprecated ListView

ryanphung commented 4 years ago

This is an improved version of the pull request created by @rollymaduk at #14. Changes:

Removed the .idea folder
Fixed an issue where the scope of this.renderList() function is gone due to its assignment in the expression (renderList || this.renderList)
Resolve conflicts in index.js
Adding SafeAreaView to KeyboardAvoidingView - otherwise on iPhone X the textbox will be pushed up too high and covered by the "notch"

This PR addresses issue #8, and probably replace PR #14 and PR #38.

@hiddentao do let me know if any updates is needed. Looking forward to having it merged because otherwise the component breaks in RN 0.60. Thank you!

hiddentao commented 4 years ago

Great work! I see you're still adding commits though. I shall wait until you feel it's complete.

ryanphung commented 4 years ago

@hiddentao it should be completed now. Let me know if you identify anything that needs to be changed or fixed!

ryanphung commented 4 years ago

@hiddentao and thank you for reviewing!

hiddentao commented 4 years ago

@ryanphung Looks good, just one small fix left.

ryanphung commented 4 years ago

@hiddentao Fixed in latest commits.

hiddentao commented 4 years ago

Thanks!

ryanphung commented 4 years ago

@hiddentao nice thank you for merging!

nihp commented 4 years ago

Whether it is working fine now?

hiddentao / react-native-modal-filter-picker