search

hielkema / postco

Postcoordination tooling Terminologiecentrum
MIT License
1 stars 0 forks source link

Errors in templates - problem with communication with snowstorm? #39

Closed pwoznicki closed 3 years ago

pwoznicki commented 3 years ago

Hello,

I was actively looking for a tool to add new concepts/create postcoordinated expressions in SNOMED CT, and I think your project enabling the creation of postcoord exp from ETL templates is a very relevant tool. Very glad someone has been working on it!

I built and started the containers in development mode, and experimented firstly with the default snowstorm address, and then with a local snowstorm server. When I go to localhost:9124 and select any available template, I get a stack of errors, beginning with: Er is een fout opgetreden bij het ophalen van een term. [focusConceptPrecoordinated] Er is een fout opgetreden bij het ophalen van een term. [templateAttributeCompact]

Moreover, when I try to type in a term into the template, the search does not return any suggested concepts (the search does not finish either). When tested with the local snowstorm server, the server has no problem with addresses and apparently returns results from queries given while typing the term. The containers are run without any errors, I get only a warning from templateservice: templateservice_1 | warn: Microsoft.AspNetCore.HttpsPolicy.HttpsRedirectionMiddleware[3]. Failed to determine the https port for redirect.

Do you have any idea how could this be fixed?

Best, Piotr

mertenssander commented 3 years ago

Hi @piotrekwoznicki , Great to hear that you've found our project!

Assuming that you haven't changed the Snowstorm server endpoint in the source code (https://github.com/mertenssander/postco#snowstorm): The error you're seeing is caused by the fact that the templates in the master branch look for a SNOMED version that is not present in our dev Snowstorm server (at the moment it only has a snapshot import of the latest release). If you use the development branch that should be fixed - I've pushed those to the latest SNOMED release. If you want to check out the tool without any management, you could go to postco.test-nictiz.nl, where we host an instance of the development branch. Of course: no guarantees on uptime on this server.

Alternatively, you could host your own snowstorm server and change every mention of snowstorm.test-nictiz.nl (https://github.com/mertenssander/postco#snowstorm) to your own snowstorm instance. At the moment there is no centralized place to change this address, that will be added in the future. Please note that the templates are version specific, and mention a specific branch as well! All templates currently present point to the Dutch extension in branch MAIN/SNOMEDCT-NL/2021-03-31. You'd have to change the branch in every template to a suitable version for your usecase by changing the version (https://github.com/mertenssander/postco/blob/49ba83546fbd25e5bc5965a0501e443b55c668bf/SnomedTemplateService/SnomedTemplateService.Web/SnomedTemplates/nictiz/ComplicatieAllergie_1615982999.xml#L13) and branch (https://github.com/mertenssander/postco/blob/49ba83546fbd25e5bc5965a0501e443b55c668bf/SnomedTemplateService/SnomedTemplateService.Web/SnomedTemplates/nictiz/ComplicatieAllergie_1615982999.xml#L14). If you need assistance with this; please let us know.

Hope this solves your issue, please let us know how you get on!

Regards, Sander

PS the error regarding the templateservice is irrelevant, maybe @basharmsen could remove this error?

mertenssander commented 3 years ago

I have just merged the development branch to master, so pulling the changes to your machine and rebuilding/recreating the containers should do the trick as well.

pwoznicki commented 3 years ago

Hi @mertenssander,

thanks for such a quick fix. It works now with updated dates! I think at postco.test-nictiz.nl there's still one template, 'Medicinal product package', that's would show errors.