search

hiendv / octicons-modular

GitHub Octicons with tree-shaking support and icon-per-file style.
MIT License
24 stars 10 forks source link

More unit tests #16

Closed hiendv closed 7 years ago

hiendv commented 7 years ago

We need more unit tests with

hiendv commented 7 years ago

Tagging @andpawlenko and @Mistereo because of their endless enthusiasm for tests :smile: We may need to discuss a little bit before getting started. Any questions, guys? Should I write some sample tests first?

hiendv commented 7 years ago

@snowyleopardz Sure but it's 1:00 AM here so I'll see you guys in the morning ;)

hiendv commented 7 years ago

I wrote some tests for individual icons and commonjs bundle here. With the extra test on this, the coverage is now 100% Coverage Status

ghost commented 7 years ago

@hiendv, @Mistereo created a good DRY and scalable solution for testing so large amount of icons. We can use the similar solution for testing individual icons. P.S. 5th line of main.commonjs covered, yeah :smile:

ghost commented 7 years ago

anyone working on this issue?

hiendv commented 7 years ago

This is a small library with a huge test suite :smile: I think people are kinda full of it. We need some tests for build scripts before closing it. I will write some tomorrow. Happy weekend.