hiendv / octicons-modular

GitHub Octicons with tree-shaking support and icon-per-file style.
MIT License
24 stars 10 forks source link

Missing dev dependency to `babel-cli` [babel-node: command not found] #22

Closed peterblazejewicz closed 7 years ago

peterblazejewicz commented 7 years ago

The build process expects babel-cli to be available:

npm run build

> octicons-modular@0.3.0 build /Users/piotrblazejewicz/git/octicons-modular
> npm run clean && babel-node --presets env build/modulize.js && npm run lint && babel-node --presets env build/build.js && npm test

> octicons-modular@0.3.0 clean /Users/piotrblazejewicz/git/octicons-modular
> rimraf lib/* && rimraf src/icons/* && rimraf src/octicons.js

sh: babel-node: command not found
npm ERR! file sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn
npm ERR! octicons-modular@0.3.0 build: `npm run clean && babel-node --presets env build/modulize.js && npm run lint && babel-node --presets env build/build.js && npm test

This can be fixed by adding babel-cli as dev dependency, unless there is an expectation that users have babel-cli installed globally.

node --version
v8.4.0
npm --version
5.4.1
macOS
hiendv commented 7 years ago

Agree.