search

hierynomus / smbj

Server Message Block (SMB2, SMB3) implementation in Java
Other
713 stars 180 forks source link

Automatic module name #582

Closed jensli closed 4 years ago

jensli commented 4 years ago

Hello!

This project would befit from adding an automatic module name to the manifest of its jar-file.

ext.moduleName = "com.hierynomus.smbj"
jar {
    inputs.property("moduleName", moduleName)
    manifest {
       attributes  'Automatic-Module-Name': moduleName
   }
}

See this article: http://branchandbound.net/blog/java/2017/12/automatic-module-name/

Without an automatic module name client code gets the following warning when building using Java >= 9:

Name of automatic module 'smbj' is unstable, it is derived from the module's file name.
hierynomus commented 4 years ago

Thanks, added this!

jensli commented 4 years ago

Nice! Thanks for a great library.

jensli commented 3 years ago

@hierynomus: Is there any chance of a new release to Maven Central so I can start using this?

hierynomus commented 3 years ago

Yes, I'm merging a few long overdue PR's (#499 and #474) after which I wanted to carve out a new release.

jensli commented 3 years ago

Thanks for your work hiery!