search

hierynomus / smbj

Server Message Block (SMB2, SMB3) implementation in Java
Other
713 stars 180 forks source link

Fix not derive signingKey in Smb3.x if not support/enable encryption #631

Closed yin19941005 closed 3 years ago

yin19941005 commented 3 years ago

Fix not derive signingKey in Smb3.x if not support/enable encryption

hierynomus commented 3 years ago

Code looks good! Can you add a test?

yin19941005 commented 3 years ago

Here you go, I extracted the part as "deriveKeys" function for easier to implement the test.

yin19941005 commented 3 years ago

I guess that's what you mean: checking other keys in deriveKeys function. The application key is not checked as it don't have a get function yet (not ready to use, I guess).