hierynomus / smbj

Server Message Block (SMB2, SMB3) implementation in Java
Other
707 stars 180 forks source link

Missing Implementation-Version and Title in MANIFEST.MF #743

Closed kaonashi97 closed 1 year ago

kaonashi97 commented 1 year ago

Hello,

this API is used in many of my applications. On a status page most of the dependencies used are displayed with name and version. Unfortunately the smbj jar doesn't include the Implementation-Version and Implementation-Title in the MANIFEST.MF. Therefore no version information is available at runtime, without reading the jar's name from the classpath or anything like that.

Implementation-Title: smbj
Implementation-Version: 0.11.5

Is there a possibility for adding the Implementation Version and Title in the manifest? Or is there another way of retrieving the version information at runtime? (e.g. static field in some class)

~Kaonashi

hierynomus commented 1 year ago

It should be possible to do this in the gradle build. That generates the manifest also.