Open hma13 opened 1 year ago
Indeed, oversight on my part, these should've been static from the get-go.
Maybe introduce a new static method that gets called from the instance methods, and mark those deprecated. That would maintain API compatibility and allow you to call the static variants directly.
Maybe a new static util class with proper static impl and Limited constructor Accessibility (momostate) and delegate and deprecate the old class?
Also makes sense to do! Let's go for that
The idea is good, but it was already released. Do you want to break the API - in that case maybe a release notes is a good ideal.
also should the class get a private constrictor if all util methods will be static?
btw the recursive implementation has no provision for hitting the share as the parent, should it check for getParent() returning this?