search

hierynomus / smbj

Server Message Block (SMB2, SMB3) implementation in Java
Other
713 stars 180 forks source link

Fix Issue #745 #753

Open hannosgit opened 1 year ago

hannosgit commented 1 year ago

Attempts to fix issue #745 "Change mkdirs to static" with the implementation proposed in the comments of the PR.

hannosgit commented 1 year ago

Should we also create the copy method in the new util class?

neon-dev commented 1 year ago

I was a bit hasty and created #757. I'd suggest implementing the pathIsFile boolean here. Also, why not copy all the code over from SmbFiles and deprecate the old class entirely? This would also simplify deleting it later.