search

hierynomus / smbj

Server Message Block (SMB2, SMB3) implementation in Java
Other
707 stars 180 forks source link

Implement message integrity (ntlmssp_mic and mechListMic) #772

Closed hierynomus closed 1 year ago

hierynomus commented 1 year ago

@Zwoca @jandornseifer Could you test this out? I think I solved the last missing piece in the authentication flow. Just need to double check I did not accidentally broke your environments after spending so much time debugging it ;)

sonatype-lift[bot] commented 1 year ago

🛠 Lift Auto-fix

Some of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.[^1]

# Download the patch
curl https://lift.sonatype.com/api/patch/github.com/hierynomus/smbj/772.diff -o lift-autofixes.diff

# Apply the patch with git
git apply lift-autofixes.diff

# Review the changes
git diff

Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command:

curl https://lift.sonatype.com/api/patch/github.com/hierynomus/smbj/772.diff | git apply

Once you're satisfied, commit and push your changes in your project. [^1]: You can preview the patch by opening the patch URL in the browser.

JanDornseifer commented 1 year ago

@hierynomus I can confirm that with 0.12.1 snapshot we can successfully connect, write and read files from customer's NAS server .

ZwoCa commented 1 year ago

@hierynomus I can also confirm it's working fine, I checked it both with NtlmConfig#withIntegrity set to false/true. 👍

ryanfetz commented 1 year ago

I just ran into this issue. When is the plan to release 0.12.1 to maven central?